This repository has been archived by the owner on Apr 14, 2023. It is now read-only.
Disable PayPal messaging when vault flow is enabled #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PayPal doesn't want you to use the messaging component when vault flow is being used. This disables the default messaging component when vault flow is on, and defaults the component to disabled (since the extensions defaults to vault flow: true)
kennyadsl
reviewed
Nov 5, 2020
| @@ -8,7 +8,7 @@ class Configuration < ::Spree::Base | |||
| label: { availables: %w[checkout credit pay buynow paypal installment], default: 'checkout' }, | |||
| tagline: { availables: %w[true false], default: 'false' }, | |||
| layout: { availables: %w[horizontal vertical], default: 'horizontal' }, | |||
| messaging: { availables: %w[true false], default: 'true' } | |||
| messaging: { availables: %w[true false], default: 'false' } | |||
There was a problem hiding this comment.
If it's disabled by default, should we explain in the readme how to enable messaging?
There was a problem hiding this comment.
I added this to the paypal financing messaging section:
To enable this option, you'll need to use the `checkout` flow, and set the `paypal button messaging` option to `true` in your Braintree configuration.
Does that work?
kennyadsl
approved these changes
Nov 5, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PayPal doesn't want you to use the messaging component when vault flow
is being used. This disables the default messaging component when vault
flow is on, and defaults the component to disabled (since the extensions
defaults to vault flow: true)