This repository has been archived by the owner on Apr 14, 2023. It is now read-only.
Fix value conversion method #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah - didn't consider that it supers, so on older versions of Solidus this will still fail. Stand by, will figure something out... |
In Solidus, this method has changed from having two parameters to having three. This updates the method here to match, so we avoid any too_many_parameter errors. Most noticably, this was affecting our test suite. See: solidusio/solidus@e05da68
seand7565
force-pushed
the
fix_value_conversion
branch
from
10e4af5 to
16d5c77
Compare
|
Due to the awkwardness of the change from 2 to 3 parameters, and needing to support multiple Solidus versions, we're using a method here that checks how many parameters Should be good for a review now! |
kennyadsl
approved these changes
Oct 9, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Solidus, this method has changed from having two parameters to
having three. This updates the method here to match, so we avoid
any too_many_parameter errors. Most noticably, this was affecting
our test suite.
See: solidusio/solidus@e05da68