This repository has been archived by the owner on Apr 14, 2023. It is now read-only.
Let PayPal button to receive locale/style parameters #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Here a full list of PayPayl button customizations](https://developer.paypal.com/docs/archive/checkout/how-to/customize-button/#interactive-code-demo)
MinasMazar
force-pushed
the
mm/i229-paypal-button-style
branch
4 times, most recently
from
01cee72 to
9dc8e8b
Compare
MinasMazar
force-pushed
the
mm/i229-paypal-button-style
branch
from
9dc8e8b to
a384d55
Compare
MinasMazar
force-pushed
the
mm/i229-paypal-button-style
branch
3 times, most recently
from
c41d69f to
de8cb94
Compare
MinasMazar
force-pushed
the
mm/i229-paypal-button-style
branch
from
de8cb94 to
673e50d
Compare
MinasMazar
pushed a commit
to nebulab/solidus_paypal_braintree
that referenced
this pull request
Oct 18, 2019
This PR solidusio#236 was incomplete since adds PayPal button customizable parameters only for checkout/payment step. This PR adds the same feature also for cart page.
MinasMazar
pushed a commit
to nebulab/solidus_paypal_braintree
that referenced
this pull request
Oct 18, 2019
This PR solidusio#236 was incomplete since adds PayPal button customizable parameters only for checkout/payment step. This PR adds the same feature also for cart page.
MinasMazar
pushed a commit
to nebulab/solidus_paypal_braintree
that referenced
this pull request
Nov 15, 2019
This PR solidusio#236 was incomplete since adds PayPal button customizable parameters only for checkout/payment step. This PR adds the same feature also for cart page.
MinasMazar
pushed a commit
to nebulab/solidus_paypal_braintree
that referenced
this pull request
Nov 15, 2019
This PR solidusio#236 was incomplete since adds PayPal button customizable parameters only for checkout/payment step. This PR adds the same feature also for cart page. Also add an ad-hoc example at cart page feautre test
MinasMazar
pushed a commit
to nebulab/solidus_paypal_braintree
that referenced
this pull request
Nov 15, 2019
This PR solidusio#236 was incomplete since adds PayPal button customizable parameters only for checkout/payment step. This PR adds the same feature also for cart page. Also add an ad-hoc example at cart page feautre test
MinasMazar
pushed a commit
to nebulab/solidus_paypal_braintree
that referenced
this pull request
Nov 15, 2019
This complete solidusio#229 since solidusio#236 was incomplete: adds PayPal button customizable parameters only for checkout/payment step. This PR adds the same feature also for cart page. Ref. solidusio#229 Ref. solidusio#236
MinasMazar
pushed a commit
to nebulab/solidus_paypal_braintree
that referenced
this pull request
Nov 15, 2019
This complete solidusio#229 since solidusio#236 was incomplete: adds PayPal button customizable parameters only for checkout/payment step. This PR adds the same feature also for cart page. Ref. solidusio#229 Ref. solidusio#236
MinasMazar
pushed a commit
to nebulab/solidus_paypal_braintree
that referenced
this pull request
Oct 9, 2020
Ref. solidusio#251 Using `Spree::CheckoutController.helper` and `Spree::OrdersController.helper` in `config/initializers/braintree.rb` to include helper modules does not work: at `checkout/payement` step an exception is raised ``` ActionView::Template::Error (undefined method `paypal_button_preference`) ``` This commit move `paypal_button_preferences` (introduced here[1]) in the already present `SolidusPaypalBraintree::BraintreeCheckoutHelper` module. [1] solidusio#236
MinasMazar
pushed a commit
to nebulab/solidus_paypal_braintree
that referenced
this pull request
Oct 15, 2020
Ref. solidusio#251 Using `Spree::CheckoutController.helper` and `Spree::OrdersController.helper` in `config/initializers/braintree.rb` to include helper modules does not work: at `checkout/payement` step an exception is raised ``` ActionView::Template::Error (undefined method `paypal_button_preference`) ``` This commit move `paypal_button_preferences` (introduced with [1]) in the already present `SolidusPaypalBraintree::BraintreeCheckoutHelper` module, and adds the same helper method to the `Spree::OrdersController` (in the same way done here [2]) to enable the button also in the cart page. [1] solidusio#236 [2] solidusio@28d0de9
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #229
Default values of Paypal button style should be the most suitable to current Solidus UX style.