This repository has been archived by the owner on Apr 14, 2023. It is now read-only.
Adopt CircleCI instead of Travis #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ci status can be seen here: https://circleci.com/gh/aldesantis/solidus_paypal_braintree |
|
Continuing the work on the specs here: https://github.com/cedum/solidus_paypal_braintree/tree/circleci |
The merchant id is present in all Braintree API urls. This adds a VCR custom request matcher that ignores the merchant id in URL. This way we can reuse the VCR cassettes independently from the configured merchant id.
|
Thanks @cedum for the help here! |
kennyadsl
approved these changes
Sep 20, 2019
|
I'm working separately on the two skipped PayPal feature specs (I'll create a separate PR). They seem to be outdated and even when failing they were dynamically marked as pending, hence testing nothing. |
kennyadsl
requested review from
spaghetticode,
ericsaupe and
jacobherrington
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.