This repository has been archived by the owner on Apr 14, 2023. It is now read-only.
Introduce 3D Secure support for credit cards #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cedum
force-pushed
the
3ds-support
branch
5 times, most recently
from
cb4512e to
312a2ea
Compare
The 3.52.0 version is the minimum version required to be able to introduce the 3D Secure 2 support.
|
rebased from master and force pushed |
|
I'm trying to figure out build failures. I think that it would be helpful to also update the README adding a bit of documentation for this option, or at least, specify that we support 3D Secure on this Payment Gateway. |
|
Added a bit of documentation on how to enable 3DS. Here's a preview: https://github.com/nebulab/solidus_paypal_braintree/tree/3ds-support#3d-secure @kennyadsl it seems the failing specs are related to sprockets v4. We may want to fix it in the Gemfile also here to v3, wdyt? |
|
Re-running specs, they should be ok now! |
|
awesome! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces 3D Secure support to satisfy the Strong Customer Authentication (SCA) requirements introduced by PSD2.
By default, 3DS is disabled. Once enabled on Braintree, it must be enabled also from Solidus Admin by checking the newly introduced checkbox in the Braintree Configuration page (see screenshot).
When enabled, here's how the checkout payment step looks:
Related issue: #162
Refs: