Stop importing address from PayPal #227
Conversation
|
I am not a fan of this. We should store the full name as The purpose of PayPal is to allow people to checkout without a user record in our database. This extension has support for being placed in the cart and we should continue supporting this, especially if we want to be listed as official PayPal extension. This feature is mandatory for that. That’s also true for Apple Pay anyway. |
Closes solidusio#226. When PayPal sends the authorization response to the server, it format the address with a single field for the first name and the last name, `recipientName`. We can’t safely infer the first name and the last name from that field (see solidusio#226), so we have to skip the user address updating. The good news is that the user address updating in this case is redundant, since Solidus always requires the address to be set before the payment happens, and such address is sent to PayPal with the `shippingAddressEditable` configuration set to `false`, so the address is necessarily the same as the one stored anyway.
mdesantis
force-pushed
the
stop-importing-address-from-paypal
branch
from
13a474a to
363bbd7
Compare
|
@tvdeyen so the current view implementation is lack of proper PayPal vault flow? I'm confused by that; the current implementation doesn't have a flow where you can skip user creation. It hasn't been implemented yet? |
|
I'm sorry, I didn't read this: https://github.com/solidusio/solidus_paypal_braintree#express-checkout-from-the-cart |
|
@mdesantis can we close this one? @tvdeyen I can't recall or find where we started deprecating |
|
@kennyadsl if we agree that this isn't the right way to fix #226 we can close it, but I'm unsure; maybe you guys have a stronger opinion about that? |
|
Hey all! Just to weigh in here (a year later): The address-import feature is definitely mandatory as far as PayPal is concerned, and as far as the name issue - firstname and lastname have been deprecated in favor of just I think we can safely close this issue - though we should definitely make sure this extension will still work when the deprecation expires 😨 |
Closes #226. When PayPal sends the authorization response to the server, it format the address with a single field for the first name and the last name,
recipientName. We can’t safely infer the first name and the last name from that field (see #226), so we have to skip the user address updating. The good news is that the user address updating in this case is redundant, since Solidus always requires the address to be set before the payment happens, and such address is sent to PayPal with theshippingAddressEditableconfiguration set tofalse, so the address is necessarily the same as the one stored anyway.