This repository has been archived by the owner on Apr 14, 2023. It is now read-only.
Raise error for invalid transactions and add specs #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luukveenis
force-pushed
the
transaction-controller-spec
branch
3 times, most recently
from
fe3de32 to
15ded52
Compare
cbrunsdon
reviewed
Sep 14, 2016
| # Creating the order also creates 3 addresses, we want to make sure | ||
| # the transaction import only creates 1 new one | ||
| order | ||
| expect { post_create }.to change { Spree::Address.count }.from(3).to(4) |
There was a problem hiding this comment.
I'd prefer .by(1) rather than from(3).to(4)
There was a problem hiding this comment.
I went back and forth on that a couple times, will change back 👍
added 3 commits
September 14, 2016 14:27
Instead of displaying the errors object's to_s, show the actual validation errors.
luukveenis
force-pushed
the
transaction-controller-spec
branch
from
15ded52 to
bb377c7
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to_s