This repository has been archived by the owner on Apr 14, 2023. It is now read-only.
Add existing payments partial #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
suggested changes
Jul 9, 2018
alepore
force-pushed
the
add-existing-payment-partial
branch
from
1385e20 to
8a75969
Compare
|
@tvdeyen oh yeah forgot that, updated! |
alepore
force-pushed
the
add-existing-payment-partial
branch
from
d346197 to
fe0af38
Compare
tvdeyen
approved these changes
Jul 18, 2018
|
@alepore this needs a rebase I guess |
kennyadsl
approved these changes
Jul 18, 2018
|
@alepore can you please rebase? 😄 |
This reverts commit 997301e. ApplePay and PayPal sources actually have some informations, they just are different than credit cards.
alepore
force-pushed
the
add-existing-payment-partial
branch
from
5a053cc to
e2a57d6
Compare
|
@kennyadsl ah, sorry, done. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #135.
It's similar to #165 but a bit more generic and simple: i think displaying the CC last digits is enough.
This should also work for Apply Pay but i did not test it.
This is what i get on vanilla Solidus:
