This repository was archived by the owner on Apr 14, 2023. It is now read-only.
Fix error display #174
Merged
Fix error display #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So the basic functionality is always available, even without the `braintree_errors` partial.
Errors are not only used for hosted fields but also for Paypal, for example.
alepore
force-pushed
the
fix-error-display
branch
from
47c1a1c to
18fed62
Compare
tvdeyen
suggested changes
Jul 9, 2018
| var errorText = errors.join(", "); | ||
|
|
||
| console.error("Error submitting transaction: " + errorText); | ||
| SolidusPaypalBraintree.showError(BraintreeError.DEFAULT + " " + errorText); |
There was a problem hiding this comment.
A validation error is not "Bad", so we should not prepend all errors with the default message.
alepore
force-pushed
the
fix-error-display
branch
from
18fed62 to
20638da
Compare
|
@tvdeyen 👍 i agree. |
|
@alepore thanks. Build is failing because of rubocop. 😢 We really should not run rubocop on Travis CI, but use Hound for this. |
Add suggested puma dependency
alepore
force-pushed
the
fix-error-display
branch
from
aafc4b3 to
db63748
Compare
Use the driver provided by capybara.
alepore
force-pushed
the
fix-error-display
branch
from
db63748 to
273ca6f
Compare
tvdeyen
approved these changes
Jul 18, 2018
|
@alepore one final rebase we are good to go. Thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently don't display transaction errors on the checkout. This behaviour is very confusing for the user.
Even if the user may not be able to fix the error by itself, we should make clear that something bad happened.
This is the result:
