This repository has been archived by the owner on Apr 14, 2023. It is now read-only.
End to end transaction #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 9, 2016 10:36
Adds the concept of a solidus transaction, representing the users interaction with braintree's javascript
| end | ||
|
|
||
| def user | ||
| order.user || nil |
added 2 commits
September 12, 2016 07:10
This is useful for payment methods that largely skip the normal checkout flow, like apple pay or paypal one touch. Will be expanded to handle addresses and extra param.
Doesn't exactly map to our addresses, so we'll pick that up in email.
cbrunsdon
force-pushed
the
end_to_end_transaction
branch
from
7d9cc66 to
e86dc28
Compare
Still need to allow customization of the import
Its pretty reasonable for solidus' use case to expect both and email and a phone.
This isn't all the javascript required to go through and end-to-end apple pay, but it provides the heavy-lifting between the frontend and the backend API's.
Not required to be used if you want to write your own, but this should get most people what they need in order to enable their payment methods.
Probably covers most peoples use cases, but feel free to override.
These didn't include phone or email, both of which are required.
stewart
force-pushed
the
end_to_end_transaction
branch
from
cd82825 to
80246fc
Compare
|
I'm not sure restricting to display_on :front_end is valid, as that will put the payment method in the "usual checkout flow", even though often we wouldn't want it to be. |
|
I was unsure of that as well - I'll remove that restriction. Scoping it to the gateway will likely be good enough. |
stewart
force-pushed
the
end_to_end_transaction
branch
from
80246fc to
2e8ce21
Compare
| last_name: ta.last_name, | ||
| city: ta.city, | ||
| country: country, | ||
| state: country.states.find_by_abbr(ta.state_code), |
There was a problem hiding this comment.
Solidus will do this for us if we simply pass in the state_code to state_name.
|
👍 Just one minor comment. Fine with either approach. |
|
|
||
| def address | ||
| transaction.address.try do |ta| | ||
| country = Spree::Country.find_by_iso(ta.country_code) |
There was a problem hiding this comment.
find_by(iso: ta.country_code)
Upcase country
This will make use of the [state_validate][1] validation in Solidus, saving us a bit of work. [1]: https://github.com/solidusio/solidus/blob/master/core/app/models/spree/address.rb#L174
Due to the order and payment having new identifiers on each run, we would never match the body of the request. Since we had VCR configured to record new episodes by default, it would just keep appending to the end of the file. This ensures the body will match by always using the same identifiers and also removes the global config option to record new episodes.
Save payment type to source
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides javascript and endpoints to execute a `SolidusPaypalBraintree::Transaction".
This
Transactionobject is intended to model an "external transaction" that takes place between a user in javascript and Braintree, for which we need to import the details of after it is completed.