Solidus passes a Spree::Payment object not the payment response code

[prdanelli]

Spree::Payment::Cancellation.cancel passes an instance of Spree::Payment to SolidusPaypalBraintree::Gateway.try_void and not the string text code.

  # Cancels a payment
  #
  # Tries to void the payment by asking the payment method to try a void,
  # if that fails create a refund about the allowed credit amount instead.
  #
  # @param payment [Spree::Payment] - the payment that should be canceled
  #
  def cancel(payment)
    # For payment methods already implemeting `try_void`
    if try_void_available?(payment.payment_method)
      if response = payment.payment_method.try_void(payment)
        payment.send(:handle_void_response, response)
      else
        payment.refunds.create!(amount: payment.credit_allowed, reason: refund_reason)
      end
    else
      # For payment methods not yet implemeting `try_void`
      deprecated_behavior(payment)
    end
  end

[tvdeyen]

Oh, boy 😞 ! How could I have missed that...

Anyway. Thanks for reporting.

I would prefer to not add this line but fix the method signature instead. Meaning rename the response_code argument (and fix the yard documentation as well), as this is just an embarrassing bug, that should be fixed asap.

[alepore]

This can be closed for #173

[tvdeyen]

@prwhitehead thanks for the contribution, but #173 superseded this