This repository has been archived by the owner on Apr 14, 2023. It is now read-only.
Restart checkout when cart Paypal button is used #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows to pass arbitrary parameters from a Paypal button to the Solidus controller.
Every time an express Paypal checkout is initiated from the cart we must reset the checkout flow. This is needed because the checkout may be in any state and the newly started Paypal checkout may send us a new, different address, thus we must recalculate all the things (taxes, shipping methods etc).
|
@luukveenis @adammathys what do you think about this? :) |
adammathys
approved these changes
Jun 8, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem:
We have two different Paypal flows here: the express checkout from the cart (address comes from Paypal) and the normal Solidus checkout (address comes from Solidus).
If an user starts the express checkout, and then comes back to the cart (from the confirm page) and restarts it with a different address, we currently don't recalculate all the address-dependent order stuff, thus we can end up with wrong taxes and shipping methods.
This is a quick solution for that: the cart button sends a special param to the Solidus controller that restarts the checkout flow.
The normal checkout flow is unaltered.
Comments or better solutions are welcome :)