This repository has been archived by the owner on Apr 14, 2023. It is now read-only.
Recalculate payment total when order total decreases #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Apple Pay does not send street address until the last step. If street is a factor in the tax calculation you will have a discrepency after the payment is made. The payment amount wasn't decreased when the order total was lower
adammathys
approved these changes
Dec 4, 2017
tvdeyen
suggested changes
Dec 5, 2017
|
I added a spec |
|
@dholdren could you please address the Rubocop offenses? Unfortunately it's part of our Travis builds and thats why its failing. NOTE TO SELF: Use HoundCI instead of Travis CI for Rubocop. |
|
@tvdeyen sorry for the long delay, the rubocop offenses have been addressed |
|
Thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is a factor in the tax calculation you will have a discrepency after
the payment is made. The payment amount wasn't decreased when
the order total was lower