This repository has been archived by the owner on Apr 14, 2023. It is now read-only.
Update TransactionAddress#state_code validation #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
approved these changes
Dec 4, 2017
Only validates this field if the country requires states. Use `Address#states_required?` for this check instead of checking objects presence.
alepore
force-pushed
the
update_state_code_validation
branch
from
4eb1528 to
d6b5262
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only validates this field if the country requires states, because this is not always true.
Example:
On an express checkout from the cart button with a german address, the state field is not present on the Paypal form and the payload we receive, because it's not required.
(On Solidus the Germany country has
states_required: true, and this is wrong.)This also uses
Address#states_required?for the check instead of checking objects presence, i think this is more correct.