This repository has been archived by the owner on Apr 14, 2023. It is now read-only.
Pend paypal spec if paypal popup not available #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It can happen that the paypal popup does not appear. We should not fail our spec when this happens.
tvdeyen
force-pushed
the
protect-against-paypal-popup-not-available
branch
from
c426866 to
688c48b
Compare
As we do not truncate but rollback the test database it happens that the ID is alrerady present and will fail the unique index.
|
Includes a fix for the hard coded ID in the client tokens controller spec as well. |
adammathys
approved these changes
Oct 27, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It can happen that the paypal popup does not appear. We should not fail our spec when this happens.