This repository has been archived by the owner on Apr 14, 2023. It is now read-only.
Rescue Braintree::NotFound errors in source display methods #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whenever we want to display a payment source during checkout or admin payments screen it may happen that the token is not known at Braintree or the token is nil. In order to not blow up these pages we should rescue these errors instead.
If last_digits returns nil (because the token is unknown) we want to display this correctly to the user as well.
tvdeyen
force-pushed
the
secure-source-display-methods
branch
from
c0667e9 to
df75c1d
Compare
adammathys
approved these changes
Oct 11, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever we want to display a payment source during checkout or admin
payments screen it may happen that the token is not known at Braintree or
the token is nil.
In order to not blow up these pages we should rescue these errors instead.