This repository was archived by the owner on Apr 14, 2023. It is now read-only.
Fix deprecated code #111
Merged
Fix deprecated code #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaacfreeman
force-pushed
the
fix/deprecations
branch
2 times, most recently
from
efd3eaf to
08387fe
Compare
added 2 commits
July 24, 2017 11:29
`update!` is deprecated, so this follows the recommendation to use `recalcualte` instead. Only specs are affected.
`Spree::Gateway` is deprecated, but called in one spec. We can use `Spree::PaymentMethod` instead.
isaacfreeman
force-pushed
the
fix/deprecations
branch
from
08387fe to
be2fefa
Compare
|
Spec failures are random. Will rebuild until it passes |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commits to address deprecation warnings that are showing up in specs.