Merge pull request #317 from tvdeyen/fix-rubocop-complaints

Rubocop -a on spec files

spec/features/frontend/venmo_checkout_spec.rb

@@ -80,7 +80,7 @@
           next_checkout_step
           finalize_checkout
 
-          expect(Spree::Order.last.complete?).to eq(true)
+          expect(Spree::Order.last.complete?).to be(true)
         end
       end
 
@@ -95,8 +95,8 @@
           next_checkout_step
           finalize_checkout
 
-          expect(Spree::Order.last.complete?).to eq(true)
-          expect(Spree::Payment.last.source.venmo?).to eq(true)
+          expect(Spree::Order.last.complete?).to be(true)
+          expect(Spree::Payment.last.source.venmo?).to be(true)
         end
       end
 
@@ -124,7 +124,7 @@
         next_checkout_step
         finalize_checkout
 
-        expect(Spree::Order.all.all?(&:complete?)).to eq(true)
+        expect(Spree::Order.all.all?(&:complete?)).to be(true)
       end
     end
   end

spec/models/solidus_paypal_braintree/source_spec.rb

@@ -26,7 +26,7 @@
 
         result = subject.save
 
-        expect(result).to eq(true)
+        expect(result).to be(true)
         expect(subject.paypal_funding_source).to be_nil
       end
 
@@ -35,9 +35,9 @@
 
         result = subject.save
 
-        expect(result).to eq(true)
+        expect(result).to be(true)
         expect(subject.paypal_funding_source).to eq('applepay')
-        expect(subject.applepay_funding?).to eq(true)
+        expect(subject.applepay_funding?).to be(true)
       end
 
       it "doesn't become nil when the payment_type is a PAYPAL" do
@@ -46,8 +46,8 @@
 
         result = subject.save
 
-        expect(result).to eq(true)
-        expect(subject.venmo_funding?).to eq(true)
+        expect(result).to be(true)
+        expect(subject.venmo_funding?).to be(true)
       end
 
       it 'becomes nil when the payment_type is a CREDIT CARD' do
@@ -56,7 +56,7 @@
 
         result = subject.save
 
-        expect(result).to eq(true)
+        expect(result).to be(true)
         expect(subject.paypal_funding_source).to be_nil
       end
 
@@ -66,7 +66,7 @@
 
         result = subject.save
 
-        expect(result).to eq(true)
+        expect(result).to be(true)
         expect(subject.paypal_funding_source).to be_nil
       end
     end
@@ -333,13 +333,13 @@
     context 'when the source token is not known at Braintree' do
       include_context 'with unknown source token'
 
-      it { is_expected.to be(nil) }
+      it { is_expected.to be_nil }
     end
 
     context 'when the source token is nil' do
       include_context 'with nil source token'
 
-      it { is_expected.to be(nil) }
+      it { is_expected.to be_nil }
     end
   end