This repository has been archived by the owner on Apr 14, 2023. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 76
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix error when saving braintree payment method
If you try to update the Braintree payment method in the admin it will throw an error due to 2 of the preference types being hashes. Solidus automatically creates a text field for these on the page, which it populates with the default value: "{}". The code inside `Spree::Preferences::Preferable` that handles type conversion throws an error if the input for a preference with type :hash is not a Hash object. This change allows for a well-formed hash to be input as a string and converts it to a Hash before saving the record.
- Loading branch information
Luuk Veenis
committed
Jan 9, 2017
1 parent
f43fae0
commit aada077
Showing
2 changed files
with
43 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -20,6 +20,35 @@ | |
end | ||
let(:payment_type) { SolidusPaypalBraintree::Source::PAYPAL } | ||
|
||
describe "saving preference hashes as strings" do | ||
subject { gateway.update(update_params) } | ||
|
||
context "with valid hash syntax" do | ||
let(:update_params) do | ||
{ | ||
preferred_merchant_currency_map: '{"EUR" => "test_merchant_account_id"}', | ||
preferred_paypal_payee_email_map: '{"CAD" => "[email protected]"}' | ||
} | ||
end | ||
|
||
it "successfully updates the preference" do | ||
subject | ||
expect(gateway.preferred_merchant_currency_map).to eq({ "EUR" => "test_merchant_account_id" }) | ||
expect(gateway.preferred_paypal_payee_email_map).to eq({ "CAD" => "[email protected]" }) | ||
end | ||
end | ||
|
||
context "with invalid user input" do | ||
let(:update_params) do | ||
{ preferred_merchant_currency_map: '{this_is_not_a_valid_hash}' } | ||
end | ||
|
||
it "raise a JSON parser error" do | ||
expect{ subject }.to raise_error(JSON::ParserError) | ||
end | ||
end | ||
end | ||
|
||
describe 'making a payment on an order', vcr: { cassette_name: 'gateway/complete' } do | ||
include_context 'order ready for payment' | ||
|
||
|