Validate payment_type on source

The payment_type is used to differ payment soruces. I.E. lots of query methods uses this column to decide which kind of payment this source instance is, even presentor methods uss this clumn to look up the human name in the translation files by this column.

Therefore it is necessary to validate its presence and add a not null constrained in the database.

app/models/solidus_paypal_braintree/source.rb

@@ -10,6 +10,8 @@ class Source < ApplicationRecord
 
     belongs_to :customer, class_name: "SolidusPaypalBraintree::Customer"
 
+    validates :payment_type, presence: true
+
     scope(:with_payment_profile, -> { joins(:customer) })
     scope(:credit_card, -> { where(payment_type: CREDIT_CARD) })
 

db/migrate/20170508085402_add_not_null_constraint_to_sources_payment_type.rb

@@ -0,0 +1,11 @@
+class AddNotNullConstraintToSourcesPaymentType < ActiveRecord::Migration
+  def change
+    reversible do |dir|
+      dir.up do
+        SolidusPaypalBraintree::Source.where(payment_type: nil).
+          update_all(payment_type: 'CreditCard')
+      end
+    end
+    change_column_null(:solidus_paypal_braintree_sources, :payment_type, false)
+  end
+end

spec/models/solidus_paypal_braintree/gateway_spec.rb

@@ -364,10 +364,19 @@
       let(:other_payment_method) { FactoryGirl.create(:payment_method) }
 
       let(:source_without_profile) do
-        SolidusPaypalBraintree::Source.create!(payment_method_id: gateway.id, user_id: user.id)
+        SolidusPaypalBraintree::Source.create!(
+          payment_method_id: gateway.id,
+          payment_type: payment_type,
+          user_id: user.id
+        )
       end
+
       let(:source_with_profile) do
-        SolidusPaypalBraintree::Source.create!(payment_method_id: gateway.id, user_id: user.id).tap do |source|
+        SolidusPaypalBraintree::Source.create!(
+          payment_method_id: gateway.id,
+          payment_type: payment_type,
+          user_id: user.id
+        ).tap do |source|
           source.create_customer!(user: user)
           source.save!
         end
@@ -429,11 +438,19 @@
           let(:user) { FactoryGirl.create(:user) }
 
           let!(:source_without_profile) do
-            SolidusPaypalBraintree::Source.create!(payment_method_id: gateway.id, user_id: user.id)
+            SolidusPaypalBraintree::Source.create!(
+              payment_method_id: gateway.id,
+              payment_type: payment_type,
+              user_id: user.id
+            )
           end
 
           let!(:source_with_profile) do
-            SolidusPaypalBraintree::Source.create!(payment_method_id: gateway.id, user_id: user.id).tap do |source|
+            SolidusPaypalBraintree::Source.create!(
+              payment_method_id: gateway.id,
+              payment_type: payment_type,
+              user_id: user.id
+            ).tap do |source|
               source.create_customer!(user: user)
               source.save!
             end

spec/models/solidus_paypal_braintree/source_spec.rb

@@ -1,7 +1,7 @@
 require 'spec_helper'
 
 RSpec.describe SolidusPaypalBraintree::Source, type: :model do
-  it 'is invalid without a payment_type set', :pending do
+  it 'is invalid without a payment_type set' do
     expect(described_class.new).to be_invalid
   end