Use VCR for CheckoutsControllerSpec

This test now creates a payment profile, and needs to be wrapped with VCR to avoid hitting the network during test runs.
solidusio · Sep 7, 2016 · 15f0fb8 · 15f0fb8
1 parent 92360a3
commit 15f0fb8
Show file tree

Hide file tree

Showing 3 changed files with 77 additions and 5 deletions.
diff --git a/app/models/solidus_paypal_braintree/gateway.rb b/app/models/solidus_paypal_braintree/gateway.rb
@@ -142,10 +142,9 @@ def create_profile(payment)
       result = Braintree::Customer.create
       customer_id = result.customer.id
 
-      customer = source.create_customer(braintree_customer_id: customer_id)
-      source.save!
-
-      customer
+      source.create_customer!(braintree_customer_id: customer_id).tap do
+        source.save!
+      end
     end
 
     # @return [String]

diff --git a/spec/controllers/solidus_paypal_braintree/checkouts_controller_spec.rb b/spec/controllers/solidus_paypal_braintree/checkouts_controller_spec.rb
@@ -4,7 +4,8 @@
 RSpec.describe SolidusPaypalBraintree::CheckoutsController, type: :controller do
   include_context 'order ready for payment'
 
-  describe 'PATCH update' do
+  cassette_options = { cassette_name: "checkouts_controller/update" }
+  describe 'PATCH update', vcr: cassette_options do
     subject(:patch_update) { patch :update, params }
 
     let(:params) do

diff --git a/spec/fixtures/cassettes/checkouts_controller/update.yml b/spec/fixtures/cassettes/checkouts_controller/update.yml