Remove Transaction#phone validation

There are situations, on Solidus or on Paypal, where we may have addresses without a phone number
solidusio · Dec 4, 2017 · 0d11b7b · 0d11b7b
1 parent e204e40
commit 0d11b7b
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 7 deletions.
diff --git a/app/models/solidus_paypal_braintree/transaction.rb b/app/models/solidus_paypal_braintree/transaction.rb
@@ -9,7 +9,6 @@ class Transaction
     validates :nonce, presence: true
     validates :payment_method, presence: true
     validates :payment_type, presence: true
-    validates :phone, presence: true
     validates :email, presence: true
 
     validate do

diff --git a/spec/models/solidus_paypal_braintree/transaction_spec.rb b/spec/models/solidus_paypal_braintree/transaction_spec.rb
@@ -8,7 +8,6 @@
         nonce: 'abcde-fghjkl-lmnop',
         payment_method: SolidusPaypalBraintree::Gateway.new,
         payment_type: 'ApplePayCard',
-        phone: "555-1234",
         email: "[email protected]"
       }
     end
@@ -51,11 +50,6 @@
       it { is_expected.to be false }
     end
 
-    context 'no phone' do
-      let(:valid_attributes) { super().except(:phone) }
-      it { is_expected.to be false }
-    end
-
     context 'no email' do
       let(:valid_attributes) { super().except(:email) }
       it { is_expected.to be false }