Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI configuration #38

Merged
merged 1 commit into from
May 3, 2023
Merged

Conversation

waiting-for-dev
Copy link
Contributor

@waiting-for-dev waiting-for-dev commented May 3, 2023

Summary

Run different Solidus versions on different jobs for better error
handling.

We're now explicitly providing the ruby version to the executor while
using a matrix configuration for better extensibility.

There's also no need to install chromedriver when chrome is already
installed.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@waiting-for-dev waiting-for-dev self-assigned this May 3, 2023
@waiting-for-dev waiting-for-dev changed the title Update CI configuration Fix CI May 3, 2023
Run different Solidus versions on different jobs for better error
handling.

We're now explicitly providing the ruby version to the executor while
using a matrix configuration for better extensibility.

There's also no need to install chromedriver when chrome is already
installed.
@waiting-for-dev waiting-for-dev force-pushed the waiting-for-dev/fix_ci branch from 6e023af to 33f9a56 Compare May 3, 2023 14:29
@waiting-for-dev waiting-for-dev changed the title Fix CI Update CI configuration May 3, 2023
@waiting-for-dev waiting-for-dev requested review from gsmendoza, kennyadsl and elia and removed request for gsmendoza and kennyadsl May 3, 2023 14:44
@waiting-for-dev waiting-for-dev merged commit 3677476 into master May 3, 2023
@waiting-for-dev waiting-for-dev deleted the waiting-for-dev/fix_ci branch May 3, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants