New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v3.2] Skip trying to install solidus_bolt when there's no Gemfile #16

Merged

waiting-for-dev merged 1 commit into v3.2 from waiting-for-dev/skip_bolt_v32

Sep 14, 2022

Contributor

waiting-for-dev commented Sep 14, 2022

Backports #15


          Skip trying to install solidus_bolt when there's no Gemfile

cce0f65

The dummy application generated within the extensions test suite lacks
the Gemfile [1]. We want to skip trying to install solidus_bolt in those
cases, as otherwise, it fails.

We keep the SKIP_SOLIDUS_BOLT environment variable behavior as that's
still useful to skip bolt when there's a Gemfile (i.e., when creating a
sandbox app). However, it can be removed from CI.

1 - https://github.com/solidusio/solidus/blob/bdebdbc15457487ab412702a02980bbbe32d3a6e/core/lib/generators/spree/dummy/dummy_generator.rb#L36

waiting-for-dev requested a review from kennyadsl

September 14, 2022 11:16

kennyadsl approved these changes

View reviewed changes

waiting-for-dev merged commit 81ddf34 into v3.2

waiting-for-dev deleted the waiting-for-dev/skip_bolt_v32 branch

September 14, 2022 11:20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet