Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix sandbox.tt variable comparison usage
When an uninitialized variable is given to `-n`, it is treated as not NULL. The variable must be quoted for correct results. `[ -n "$SOLIDUS_BRANCH" ]` It is also recommended for variable comparisons in general as it can produce incorrect results for `! -z`. References: - https://tldp.org/LDP/abs/html/comparison-ops.html - https://tldp.org/LDP/abs/html/comparison-ops.html#STRTEST This meant that before, when running this file with no SOLIDUS_BRANCH variable, $BRANCH would end up NULL and the branch in the Gemfile would be an empty string. This caused an error, whereas instead, it should have defaulted to `master`. Error: ``` fatal: Needed a single revision Git error: command `git rev-parse --verify ''` in directory /Users/ryanwoods/.rbenv/versions/2.7.6/lib/ruby/gems/2.7.0/cache/bundler/git/solidus-169f1ecb1aee2122950e6d586daf2410f62df66e has failed. Revision does not exist in the repository https://github.com/solidusio/solidus.git. Maybe you misspelled it? If this error persists you could try removing the cache directory '/Users/ryanwoods/.rbenv/versions/2.7.6/lib/ruby/gems/2.7.0/cache/bundler/git/solidus-169f1ecb1aee2122950e6d586daf2410f62df66e' The git source https://github.com/solidusio/solidus.git is not yet checked out. Please run `bundle install` before trying to start your application ```
- Loading branch information