Update how braintree client tokens are generated (Implementation 2) #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To promote a one to one relationship between braintree customers and spree users, add the braintree customer id to the spree_users table. Anytime a new client token is generated for a new payment method, pass that customer id in as one of the options so that all new payment methods are added to the same braintree customer associated to the spree user.
ericsaupe
suggested changes
Feb 20, 2019
skukx
commented
Feb 21, 2019
| options[:customer_id] = user.braintree_customer_id if user.present? | ||
|
|
||
| braintree_gateway.generate_client_token(options) | ||
| rescue => error |
There was a problem hiding this comment.
I'm curious on thoughts about rescuing here. I rescue so that we don't return a 500 resulting in the user not getting a rendered page (Maybe braintree is down).
This is important as a customer may not even be using the Braintree payment method and we don't want to block them completely
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To promote a one to one relationship between braintree customers and
spree users, add the braintree customer id to the spree_users table.
Anytime a new client token is generated for a new payment method, pass
that customer id in as one of the options so that all new payment
methods are added to the same braintree customer associated to the spree
user.