Use new access denied extension point.

[adammathys]

Class attribute added in solidusio/solidus#179 allows us to more easily define the behaviour we want for the extension.

[gmacdougall]

👍

[athal7]

i'm not a huge fan of this, can we find another way to decorate solidus?

[adammathys]

@athal7: Updated to hook into Solidus a bit nicer. What do you think?

Tests will fail until solidusio/solidus#179 is merged. Running locally everything is green.

[athal7]

i'm still curious why this is here as opposed to in core, though that's not central to what you're doing here.

[adammathys]

Neither am I. Wanted to limit the number of changes in this pull-request so I didn't spend any time looking into whether this is even necessary.

[athal7]

looks great!

[jhawthorn]

👍

[BenMorganIO]

Writing rescue_from CanCan::AccessDenied always felt accessible to me. I can't seem to figure out how to extend this in decorators.

# GET /admin/orders

Spree::BaseController.unauthorized_redirect = -> { redirect_to main_app.root_path }

Spee::BaseController.class_eval do
  unauthorized_redirect = -> do
    redirect_to main_app.root_path
  end

  def self.unauthorized_redirect
    -> { redirect_to main_app.root_path }
  end
end

Spree::Admin::BaseController.unauthorized_redirect = -> { redirect_to main_app.root_path }

Spee::Admin::BaseController.class_eval do
  unauthorized_redirect = -> do
    redirect_to main_app.root_path
  end

  def self.unauthorized_redirect
    -> { redirect_to main_app.root_path }
  end
end

# => GET /admin/login

None of these worked for me, however, using rescue_from brought me some desired results, but still not up to what I needed.

Spree::Admin::BaseController.class_eval do
  rescue_from CanCan::AccessDenied do |_exception|
    render file: 'public/404.html', layout: false, status: 404
  end unless Rails.env.development?
end

# GET /admin
# => 404

# GET /admin/orders
# => 302

[BenMorganIO]

Note to self and to anyone stumbling across via Google, don't forget to use self:

Spee::Admin::BaseController.class_eval do
  self.unauthorized_redirect = -> { ... }
end