Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use of helper_method should be wrapped in respond_to? check #90

Closed
stewart opened this issue May 6, 2017 · 0 comments
Closed

Use of helper_method should be wrapped in respond_to? check #90

stewart opened this issue May 6, 2017 · 0 comments

Comments

@stewart
Copy link
Contributor

stewart commented May 6, 2017

As in solidus_core, solidus_auth_devise makes of the helper_method function provided by AbstractController. This method is not included in API-only applications, and should be wrapped with respond_to? checks, as Devise has done.
stewart added a commit to stewart/solidus_auth_devise that referenced this issue May 22, 2017
@stewart
Wrap use of helper_method in respond_to?
2125897 
This is considered the "safe" way to invoke `helper_method` in Rails
engines, as it is not available in some contexts, for example in
API-only applications.

Fixes solidusio#90.
@stewart stewart mentioned this issue May 22, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stewart