Add affirm gateway partial #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennyadsl
force-pushed
the
kennyadsl/add-gateway-partial
branch
2 times, most recently
from
8b34189 to
a698145
Compare
This allows to use solidus support stuff into the engine file.
This is only used in latest versions of solidus and would raise an exception if this is not present.
kennyadsl
force-pushed
the
kennyadsl/add-gateway-partial
branch
3 times, most recently
from
210446c to
970ee57
Compare
tvdeyen
approved these changes
Jan 4, 2019
lib/solidus_affirm/backward_compatibility_hacks/api_template.rb
Outdated
Show resolved
Hide resolved
kennyadsl
force-pushed
the
kennyadsl/add-gateway-partial
branch
from
970ee57 to
074b131
Compare
This basically dynamically adds some methods on SolidusAffirm::Checkout class. Those methods are called by the order show API endpoint in Solidus core prior to 2.6. After that version we'll use a dedicated partial for each payment source. We didn't notice this issue since the enpoint were not tested into this extension.
kennyadsl
force-pushed
the
kennyadsl/add-gateway-partial
branch
from
074b131 to
3a76db2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a specific partial for Affirm payment sources.
This is needed after solidusio/solidus#2513