Privatize TaxRate#default_zone_or_zone_match #915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method is an implementation detail (not the nices btw) of the current taxation system, and is only ever called from within tax_rate.rb. It's only relevant for VATs, untested, and generally a pain that I want to be able to freely change.
|
👍, good by me thanks. |
|
👍 |
jhawthorn
added a commit
that referenced
this pull request
Feb 26, 2016
Privatize TaxRate#default_zone_or_zone_match
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method is an implementation detail (not the nicest btw) of the
current taxation system, and is only ever called from within tax_rate.rb.
It's only relevant for VATs, untested, and generally a pain that I want to
be able to freely change.