[Admin] Adjustment Reasons edit/update #5815
Conversation
The new adjustment reasons were always being created with `active: true` regardless of the checkbox state. This commit fixes that issue so that the checkbox state is respected and allows users to control the active state.
The human-readable output is the same regardless of which model we are referencing here, (always "Active") but since this is the AdjustmentReason component, let's be consistent and reference that here.
MadelineCollier
force-pushed
the
admin-update-adjustment-reason
branch
from
cbb6253 to
09a30db
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5815 +/- ##
==========================================
- Coverage 88.80% 88.78% -0.02%
==========================================
Files 732 733 +1
Lines 17088 17114 +26
==========================================
+ Hits 15175 15195 +20
- Misses 1913 1919 +6 ☔ View full report in Codecov by Sentry. |
This should consistently use either uppercase or lowercase. Since the others use lowercase, I went with that.
MadelineCollier
force-pushed
the
admin-update-adjustment-reason
branch
from
09a30db to
364aec2
Compare
|
Looked at trying to up my coverage % for this PR, but couldn't find a worthwhile way of testing failed updates without introducing controller specs in addition to our feature specs. Since I didn't see any controller specs for our existing controllers, I hope the feature specs I provided on this PR should be good enough, but let me know if you'd like me to have a longer look at this or if you have any suggestions. 
In the meantime, I'll leave this PR as is for someone else to make the call on merging it. |
Summary
This PR is for this issue but it doesn't have an issue ID yet as the issue is still in draft and there is a GitHub bug preventing opening the issue.
This PR migrates the editing/updating of existing adjustment reasons to the new admin interface, following the existing pattern used for tax categories.
The form is rendered via a modal dialog on the adjustment reasons list by leveraging Turbo frames. Successful updating leads to a turbo stream page refresh, which updates the existing list preserving the query params and the scroll position, for a consistent UX.
The attached video shows the functionality visually:
Screen.Recording.2024-08-08.at.5.32.56.PM.mov
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: