[WIP] Remove after_rollback from LogEntry #564
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❤️ 👍 This has plagued us for a long time. Thank you for taking the time to investigate and clean this mess up. |
|
That this breaks no specs terrifies me. @jhawthorn should we try and get this in really early into 1.3 as well? Also, we should write a spec that actually does something for this. As in: given we have a payment that fails, a log entry of it still exists. We should probably do that before we merge. |
|
Tagged for 1.3. We should make sure there is a spec covering payment failures. |
This is trying to assign the payment's source to source. Not only is that the wrong thing to do (a payment is the source of a log_entry), but since it's being built through the payment.log_entries association, it will have no effect. Sometimes two wrongs do make a right!
jhawthorn
force-pushed
the
leaky_database
branch
from
22a29e9 to
bf3e2f8
Compare
|
Closing as stale. Please reopen if this is still something we want to tackle. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP because I'm not yet 100% certain that removing that has no effect, need to test a bit more.
after_rollbackhas all kinds of problems. When it's run as part of our specs, the filter happens after our spec run (each spec is run inside a transaction), meaning that extra useless blank log entries end up in our database. Gross!In core's test suite:
I don't think we ever want this, if we were rolling back a log entry, we would also be rolling back a state change on a payment, which is bad.
This is similar to bc19fcb