Bundle solidus_admin >= 0.2 in Solidus installer #5607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, running `rails g solidus:install` on a new rails app bundles `solidus_admin` with version `0.0.0`, which is empty. This leads to inconsistencies, the first one being the dedicated `solidus_admin` generator is not found and consequently cannot be run.
github-actions
bot
added
the
changelog:solidus_core
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5607 +/- ##
=======================================
Coverage 88.63% 88.63%
=======================================
Files 683 683
Lines 16299 16299
=======================================
Hits 14446 14446
Misses 1853 1853 ☔ View full report in Codecov by Sentry. |
adammathys
approved these changes
Jan 19, 2024
rainerdema
approved these changes
Jan 22, 2024
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently, running
rails g solidus:installon a new rails app bundlessolidus_adminwith the version0.0.0, which is empty.This leads to inconsistencies, the first one being the dedicated
solidus_admingenerator is not found and consequently cannot be run. Confirmed to be the source of the issue found at #5606.Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: