Move factory_bot static attrs to dynamic #2831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skukx
approved these changes
Aug 23, 2018
tvdeyen
approved these changes
Aug 29, 2018
|
@fastjames a rebase with latest master should fix the build errors |
Factory_bot is now flagging static factory attributes as deprecated, pending removal in version 5.0.
fastjames
force-pushed
the
factory_dynamic_attributes
branch
from
00b90f1 to
749691e
Compare
kennyadsl
approved these changes
Sep 2, 2018
kennyadsl
added a commit
to nebulab/solidus
that referenced
this pull request
Jan 22, 2019
We already converted the rest of the factories attributes to dynamic into solidusio#2831 but after merging that PR, we merged solidusio#2798 which was pretty old and was still using the old "way".
4 tasks
This was referenced Feb 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Factory_bot is now flagging static factory attributes as deprecated,
pending removal in version 5.0. This is adding a lot of noise to test output, which makes it harder to see more important failures.