Fix admin payment actions style table issue #2589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
requested changes
Feb 20, 2018
|
@tvdeyen I just changed the approach, what do you think? |
tvdeyen
reviewed
Feb 21, 2018
| @@ -1,4 +1,4 @@ | |||
| <table class="index" id='payments' data-order-id='<%= @order.number %>'> | |||
| <table class="index table table-sm table-responsive" id='payments' data-order-id='<%= @order.number %>'> | |||
There was a problem hiding this comment.
Could we not change the table style here? Won’t adding just table-responsive be enough to fix the issue?
There was a problem hiding this comment.
I just tested it and yes, we can use only table-responsive, I sent the changes https://github.com/solidusio/solidus/pull/2589/files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does?
Solves: #2535
Preview
http://recordit.co/hR8Qjd0k61
Reference