Better organize stock management JS and convert from coffeescript #2548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmacdougall
approved these changes
Feb 2, 2018
jhawthorn
force-pushed
the
stock_management_js
branch
from
4c78429 to
36eaf0b
Compare
Also convert from CoffeeScript to plain JS
Previously this was two separate very short CoffeeScript files. This commit converts them to plain JS and combines them into a single file.
jhawthorn
force-pushed
the
stock_management_js
branch
from
36eaf0b to
59ad9a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were backbone-ified already, but were created before we had created the
Spree.ViewsandSpree.Stocknamespaces.This PR moves the existing views and model into that namespace and folders. It also converts the existing CoffeeScript into plain JS.
There should be no change to users