Improve deprecation message for 'deprecated_method_type_override' #2494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordan-brough
force-pushed
the
improve-deprecation-message
branch
from
17073a7 to
b719cc6
Compare
Previously stack trace line that the deprecation message would print was the `#partial_name` method inside PaymentMethod itself, which isn't very helpful. Also, print out corresponding class name.
jordan-brough
force-pushed
the
improve-deprecation-message
branch
from
b719cc6 to
4b6ec70
Compare
jordan-brough
changed the title
jhawthorn
approved these changes
Jan 9, 2018
mamhoff
approved these changes
Jan 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the stack trace line that the deprecation message would print was
the
#partial_namemethod inside PaymentMethod itself, which isn't veryhelpful.
Also, print out corresponding class name.