Fixes for MySQL #2468
Merged
Fixes for MySQL #2468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "where" clause of this unique index doesn't work under MySQL, which indexes the whole table. Previously it was wrapped in an if condition. This was broken as part of the roll-up migration.
tvdeyen
approved these changes
Dec 22, 2017
There was a problem hiding this comment.
Nice! Thanks
With CircleCI 2.0 workflows we now can build matrices https://discuss.circleci.com/t/build-matrix-configuration/14448
Maybe we should start to test against MySQL as well? We do for all extensions, though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a few issues with MySQL.
Notably, the roll-up migration added a database partial index which only worked properly under MySQL. This PR changes the migration to only add the index on databases supporting partial indexes.