Adjustments documentation #2459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These Spree models are not available in Solidus. If we require a section about extending adjustments or creating new adjustables in Solidus, it would have to be rewritten from scratch.
Previously, the adjustment scopes and associations listed were the last documented for Spree. Now, there's up-to-date for the current version of Solidus.
swcraig
reviewed
Dec 19, 2017
guides/adjustments/adjustments.md
Outdated
| price of the object it is associated with. Otherwise, the adjustment is added | ||
| to the total price. This property only applies to tax adjustments. See the | ||
| taxation documentation for more information. | ||
| included in the price. |
There was a problem hiding this comment.
Something got chopped here.
8 tasks
benjaminwil
force-pushed
the
adjustments_documentation
branch
from
d551400 to
7fc8b45
Compare
I've been looking for an easy way to add positive adjustment fees/charges based on rules, and I think I need a custom adjuster. Specifically, I need the opposite of a promotion - i.e. a charge if there's only 1 item of a specific product or a charge per quantity of another product (such as a disposal fee). I was directed to look into creating custom calculators, but I don't think charges/fees fit wherever promotions are called. |
kennyadsl
approved these changes
Mar 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've ported the Spree documentation for adjustments and updated it for Solidus.
The Spree documentation had an additional section for extending adjustments, but it wasn't relevant for Solidus and am not positive that it'd be a useful section for Solidus developers.
If someone can give me an example of why you'd want to add a new adjustable or create custom adjustments, I would love to learn more about it.
Once we have taxation and promotions documentation merged, I'd like to come back to this and add relevant links.
This is part a larger project to improve Solidus's documentation. See this gist with the high-level table of contents. Where and how this documentation will exist is still up for discussion.