Remove zombie tooltips with MutationObserver #2421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build errors will be fixed by #2423 |
Instead of polling the tooltip to see if it is still hovered, this commit introduce a mutation observer in order to remove the tooltip of elements that are removed from the DOM.
kennyadsl
force-pushed
the
improve-tooltips
branch
from
8a9ec17 to
1df1f3b
Compare
jhawthorn
approved these changes
Dec 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we were removing tooltips of elements that are removed from DOM (they remain on the page permanently) by polling the element to see if it's still hovered.
Instead of polling the tooltip to see if it is still hovered, this commit introduce a mutation observer.