Improve admin return authorization controller #2420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build errors will be fixed by #2423 |
kennyadsl
force-pushed
the
add-return-authorization-specs
branch
from
b2c8006 to
74dd5b7
Compare
|
After talking with @gmacdougall we agreed that it's better to whitelist the accepted methods here. As a next step it will probably make sense to try to refactor the logic that required this |
This commit whitelist actions fireable with this action to state machine events only. We don't want to let this action accept all methods that ends with ! (like .destroy!). This is not considered a security issue since this action is restricted to admin only.
kennyadsl
force-pushed
the
add-return-authorization-specs
branch
from
74dd5b7 to
553f8e4
Compare
gmacdougall
approved these changes
Jun 6, 2018
|
The only possible event is As next iteration we could remove this |
tvdeyen
approved these changes
Jun 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #2284 we noticed we had no specs for the
fireaction in admin ReturnAuthorization controller.This PR adds specs for that method and handle when trying to fire a method that does not exist on the ReturnAuthorization instance.