Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uniform how we create sample store in deafult and sample data #2405

Merged
merged 1 commit into from
Nov 27, 2017

Conversation

kennyadsl
Copy link
Member

Also, we are not creating a store in migrations since #2229, but populating database with default data and sample data (for example creating the sandbox) is creating two different stores.

Also, we are not creating a store in migrations since solidusio#2229, but
populating database with default data and sample data (for example
creating the sandbox) is creating two different stores.
@kennyadsl kennyadsl self-assigned this Nov 25, 2017
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for removing this long lasting annoyance

Copy link
Contributor

@jhawthorn jhawthorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jhawthorn jhawthorn merged commit 2116839 into solidusio:master Nov 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants