Change make_permalink behaviour #2341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Order has its own logic for generating permalinks, we should use that exclusively.
This lock was well-intentionned, but doesn't do anything to reduce the likelyhood of a duplicate permalink.
mamhoff
approved these changes
Nov 1, 2017
kennyadsl
approved these changes
Nov 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The behaviour here wasn't what anyone wanted (fixing duplicate generated identifiers by appending
-1,-2, etc) and had major performance issues (selecting ordersLIKE "R123123%"inside of a lock).This removes
make_permalinkfrom Order, which has its own number generator, which we should use exclusively.This replaces the old
make_permalinkbehaviour in favour of generating a brand new permalink if one already exists.Thanks @jarednorman for discovering the performance issue.