Remove render_404 from frontend #2329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't think the original intention of this spec was for the controller to error. This wasn't noticed because the error was being swallowed by rescue_from render_404.
Rails knows how to render a 404, so this is unnecessary and can hide errors. Doing this is also necessary in order to test without full rails installation directory (specifically with a public/404.html).
kennyadsl
added a commit
to solidusio-contrib/solidus_reviews
that referenced
this pull request
Nov 3, 2017
This method has been remove from solidus with solidusio/solidus#2329
This was referenced Nov 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #2281
Rails knows how to render a 404, so this is unnecessary and can hide errors.
Some users will have used this to override the behaviour. These users can either re-add the
rescue_froms in their own app, or use Rails'sconfig.exception_app.