Use translated model names in admin payment methods form #1975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to rebase #1974 if we decide to make this change |
tvdeyen
added
Code review needed
changelog:solidus_backend
tvdeyen
force-pushed
the
cleanup-payment-methods-form
branch
from
c3dc09d to
1f45df4
Compare
|
Rebased, ready to review |
|
Looks even better with #2040
|
tvdeyen
force-pushed
the
cleanup-payment-methods-form
branch
from
302f504 to
9842111
Compare
Currently the admin payment methods form uses a mix of payment_method and the payment methods class name params key. This is due to the STI nature of payment methods. By using the :as feature from Rails' form_for helper we remove code from the controller that merges these to kind of params hashes into one and reduce clutter in the form.
tvdeyen
force-pushed
the
cleanup-payment-methods-form
branch
from
9842111 to
9b48a2c
Compare
|
Rebased again. Still ready for review |
jhawthorn
changed the title
- Use a checkbox in stead of two radio buttons to represent the active value. - Move autocapture select above check boxes - Use available space
jhawthorn
force-pushed
the
cleanup-payment-methods-form
branch
from
9b48a2c to
a81f974
Compare
jhawthorn
approved these changes
Jul 19, 2017
|
We're going to backport and include this in 2.3.0. Since 2.3.0 includes the renames of the bogus payment method classes, it makes sense to include this and have them human readable (and also would avoid changing how they're displayed here in two separate consecutive releases). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is one of many that follow to remove the confusion around payment methods, payment providers and gateways we have for a long time in our code base.
There is lots of confusing parts in administrating payment methods:
Before
After