Remove js.erb response for prices#new and add breadcrumbs

[jhawthorn]

The new link was previously using remote: true and a js.erb template which replaced the main body of the page with the new form. This PR changes it to link to the new url normally.

This fixes a minor bug where the NumberWithCurrency JS component wasn't being initialized on the dynamically added content. It also allows having the breadcrumbs and title change correctly.

If we wanted the benefits of the old behaviour (avoiding full page load), we should use turbolinks.

[tvdeyen]

Good catch 👍

[tvdeyen]

we should use turbolinks.

That's something I really want to look into next. Now that our JS is better organized this should be easy to accomplish.

[mtomov]

we should use turbolinks.

That's something I really want to look into next. Now that our JS is better organized this should be easy to accomplish.

👍

I have been thinking the same those past couple of days, and even looked briefly at jquery.turbolinks

[tvdeyen]

✅ #1863

I have been thinking the same those past couple of days, and even looked briefly at jquery.turbolinks

jquery.turbolinks does not support Turbolinks 5 and is not needed by us. There might be an extension or store that uses an old jquery plugin that makes internal use of dom:ready, but this is most likely very rare.

Extensions and stores DO have to use Spree.ready in stead of jQuery.ready though. But this is a simple search and replace update.