Remove adjustment updates in Shipment#update_amounts #1435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously calling Shipment#update_amounts (usually done by the OrderUpdater) would update the cost on the Shipment as well as call update! on all adjustments and update the Shipment's adjustment_total. When used as part of an OrderUpdate this isn't necessary as the adjustments will be updated later in the process.
|
👍 nice! |
|
👍 Thanks John! |
|
👍 🎆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously calling
Shipment#update_amounts(usually done by theOrderUpdater) would update the cost on the Shipment as well as call update! on all adjustments and update the Shipment'sadjustment_total.When used as part of an
OrderUpdatethis isn't necessary as the adjustments will be updated later in the process.This relates to #1252 where @jordan-brough suggests we should no longer update adjustments outside of
OrderUpdater.