Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admin Product page for a deleted item shows errors when clicking around #1987

Closed
andoneve opened this issue Jun 2, 2017 · 1 comment
Closed

Admin Product page for a deleted item shows errors when clicking around #1987

andoneve opened this issue Jun 2, 2017 · 1 comment

Comments

@andoneve
Copy link
Contributor

andoneve commented Jun 2, 2017

Steps to reproduce

  1. delete an item from the products list
  2. check 'Show Deleted' and hit 'Search'
  3. click on deleted item
  4. click 'Images', 'Variants', 'Prices' and 'Product Property' tabs --> throw errors

Expected behavior

Those tabs should be hidden if they give errors

Actual behavior

Tabs are all shown and clickable

System configuration

Solidus Version:
solidusio/solidus/master at 4354667

Gemfile.lock
@andoneve
Copy link
Contributor Author

andoneve commented Jun 2, 2017

'Product Stock' doesn't make sense either because the page just says 'Stock Item Not Found'. hiding that tab, too.

@andoneve andoneve mentioned this issue Jun 2, 2017
Merged
andoneve pushed a commit to andoneve/solidus that referenced this issue Jun 8, 2017
Do not show broken links in deleted product view
4b7d470 
Fixes solidusio#1987 - Admin product page for a deleted item shows errors when clicking around.
Hides the broken tabs if the product is deleted. Broken: Images, Prices,
Product Properties and Product Stock.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@andoneve