Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give users a way to remove the message bar from the style guide #1958

Closed
Mandily opened this issue May 23, 2017 · 1 comment
Closed

Give users a way to remove the message bar from the style guide #1958

Mandily opened this issue May 23, 2017 · 1 comment

Comments

@Mandily
Copy link
Contributor

Mandily commented May 23, 2017

Steps to reproduce

  • Scroll down to the flashes section of the style guide
  • Click on any of the buttons
  • See the resulting banners persist on the page until it's refreshed

Expected behaviour

  • Give the user a button to "Close open flash messages"
  • Each type of flash message should only appear once

screen shot 2017-05-23 at 3 10 46 pm
@mtylty
Copy link
Contributor

mtylty commented May 23, 2017

Will PR shortly.

mtylty added a commit to nebulab/solidus that referenced this issue May 23, 2017
@mtylty
Improve style guide flash messages UX
e915848 
Make flash messages in the style guide disappear when clicked upon and
avoid showing multiple flash messages of the same instance if clicked
multiple times.

Ref. solidusio#1958
@mtylty mtylty mentioned this issue May 23, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tvdeyen @mtylty @kennyadsl @Mandily