Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor SolidusDefaults#add_pages via #add_page #15

Merged
merged 1 commit into from
Jun 21, 2019
Merged

Refactor SolidusDefaults#add_pages via #add_page #15

merged 1 commit into from
Jun 21, 2019

Conversation

MinasMazar
Copy link
Contributor

@MinasMazar MinasMazar commented Jun 7, 2019 •
edited
Loading

  • resolve Todo (the code is taken from an outdated PR ).
  • fix typo

Refactor SolidusDefaults#add_pages via #add_page
b15a74f 
+ resolve Todo (the code is taken from an outdated PR
  #10)
+ fix typo
spaghetticode
spaghetticode approved these changes Jun 14, 2019
View reviewed changes
Copy link
Member

@spaghetticode spaghetticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍰 looks good to me, thank you @MinasMazar 👍

@MinasMazar MinasMazar merged commit d4a45a2 into master Jun 21, 2019
@MinasMazar MinasMazar mentioned this pull request Jun 21, 2019
Closed
@MinasMazar MinasMazar deleted the mm/refactor branch August 9, 2019 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spaghetticode spaghetticode spaghetticode approved these changes

@kennyadsl kennyadsl Awaiting requested review from kennyadsl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MinasMazar @spaghetticode